Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Code prettification and bugfixing #3250

Merged
merged 17 commits into from Jan 2, 2020
Merged

[Admin] Code prettification and bugfixing #3250

merged 17 commits into from Jan 2, 2020

Conversation

Flame442
Copy link
Member

@Flame442 Flame442 commented Jan 1, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

FIXES:
-Fixed some badly worded strings
-Fixed role managing commands not properly checking if the bot had manage_roles perms
-Fixed [p]editrole commands not checking if roles are higher than the bot's highest role
-Fixed [p]announce ignore and [p]announce channel not being able to be used by non bot owners due to a top level @checks.is_owner()

REMOVALS:
-Removed Admin tests
-Removed the MemberDefaultAuthor converter because its only purpose seemed to be catching ""

ENHANCEMENTS:
-The SelfRole converter now only makes a config get call when the role actually exists
-Moved [p]announce ignore and [p]announce channel to be under [p]announceset instead
-Moved [p]selfrole <role> to [p]selfrole add <role>
-Moved [p]selfrole add to [p]selfroleset add
-Moved [p]selfrole delete to [p]selfroleset remove

@Flame442 Flame442 added Type: Enhancement Type: Fix labels Jan 1, 2020
@Flame442 Flame442 added the Type: Removal label Jan 1, 2020
@Flame442 Flame442 added this to the 3.2.1 milestone Jan 2, 2020
@mikeshardmind mikeshardmind merged commit e776b5c into Cog-Creators:V3/develop Jan 2, 2020
1 check passed
@mikeshardmind mikeshardmind removed this from the 3.2.1 milestone Jan 2, 2020
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 2, 2020
@Flame442 Flame442 deleted the patch-2 branch Jan 2, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Type: Enhancement Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants