Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Code prettification and bugfixing #3250

Merged
merged 17 commits into from Jan 2, 2020

Conversation

@Flame442
Copy link
Member

Flame442 commented Jan 1, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

FIXES:
-Fixed some badly worded strings
-Fixed role managing commands not properly checking if the bot had manage_roles perms
-Fixed [p]editrole commands not checking if roles are higher than the bot's highest role
-Fixed [p]announce ignore and [p]announce channel not being able to be used by non bot owners due to a top level @checks.is_owner()

REMOVALS:
-Removed Admin tests
-Removed the MemberDefaultAuthor converter because its only purpose seemed to be catching ""

ENHANCEMENTS:
-The SelfRole converter now only makes a config get call when the role actually exists
-Moved [p]announce ignore and [p]announce channel to be under [p]announceset instead
-Moved [p]selfrole <role> to [p]selfrole add <role>
-Moved [p]selfrole add to [p]selfroleset add
-Moved [p]selfrole delete to [p]selfroleset remove

Flame442 added 6 commits Jan 1, 2020
Flame442 added 11 commits Jan 1, 2020
...
@Flame442 Flame442 added this to the 3.2.1 milestone Jan 2, 2020
@mikeshardmind mikeshardmind merged commit e776b5c into Cog-Creators:V3/develop Jan 2, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@mikeshardmind mikeshardmind modified the milestones: 3.2.1, 3.2.0 Jan 2, 2020
@Flame442 Flame442 deleted the Flame442:patch-2 branch Jan 2, 2020
Drapersniper added a commit to Drapersniper/Red-DiscordBot that referenced this pull request Jan 16, 2020
* Facelift for Admin

* Remove unnecessary converter, reorder existing steps

* Delete admin.py

* Delete __init__.py

* Delete test_admin.py

* Remove one extra unneeded check

* Create 3250.bugfix.1.rst

* Create 3250.bugfix.2.rst

* Create 3250.bugfix.3.rst

* Create 3250.bugfix.4.rst

* Create 3250.misc.1.rst

* Create 3250.misc.2.rst

* Create 3250.misc.3.rst

* Create 3250.breaking.1.rst

* Create 3250.breaking.2.rst

* ...

* I hate black...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.