Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add Red.wait_until_red_ready() function to wait until post connection startup is done #3273

Merged
merged 5 commits into from Jan 5, 2020

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Jan 5, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

I'm open to suggestion for better name :P

  • add bot.wait_until_red_ready() method that waits until our post connection startup is done.
  • bot.owner_id is now set in our post connection startup.
  • bot.get_owner_notification_destinations() (and bot.send_to_owners()) will now wait until Red is done with post connection startup to ensure owner ID is available
  • bot.get_owner_notification_destinations() (and bot.send_to_owners()) will now log that they weren't able to find owner notification destination

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 5, 2020
@mikeshardmind mikeshardmind added the Type: Enhancement label Jan 5, 2020
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jan 5, 2020

Looks good at a glance. This may also resolve an open issue where someone had inconsistent results with this. I'll do a fuller review later.

@mikeshardmind mikeshardmind self-assigned this Jan 5, 2020
@mikeshardmind mikeshardmind merged commit b0f840c into Cog-Creators:V3/develop Jan 5, 2020
2 checks passed
@jack1142 jack1142 deleted the V3/cache_owners branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants