[Core] Add Red.wait_until_red_ready() function to wait until post connection startup is done
#3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshardmind
added
the
Type: Enhancement
|
Looks good at a glance. This may also resolve an open issue where someone had inconsistent results with this. I'll do a fuller review later. |
3 tasks
mikeshardmind
approved these changes
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Type
Description of the changes
I'm open to suggestion for better name :P
bot.wait_until_red_ready()method that waits until our post connection startup is done.bot.owner_idis now set in our post connection startup.bot.get_owner_notification_destinations()(andbot.send_to_owners()) will now wait until Red is done with post connection startup to ensure owner ID is availablebot.get_owner_notification_destinations()(andbot.send_to_owners()) will now log that they weren't able to find owner notification destination