Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core, Downloader] Clear lib folder on minor Python version change, add [p]cog reinstallreqs command #3274

Merged
merged 7 commits into from Jan 6, 2020

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Jan 5, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

These changes depend on #3273, don't merge this before it.

  • added [p]cog reinstallreqs command that allows to reinstall cog requirements and shared libraries for all installed cogs (resolves #3167)
  • lib folder is now cleared on minor Python version change and bot is getting loaded with no cogs when they're cleared, message explaining what to do is sent to owners

I used [p] in message to owner cause I'm not sure what's the approved™ way of getting prefix when I don't have Context object, I can change it once someone tells me how.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 5, 2020
@mikeshardmind mikeshardmind added the Blocked By: Other PR label Jan 5, 2020
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jan 5, 2020

if you manually get the destinations and handle the sending yourself, you can ask the bot about the correct prefix for that destination.

@mikeshardmind mikeshardmind removed the Blocked By: Other PR label Jan 5, 2020
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Looks mostly ready to go now, just one small thing to prevent accidental spam

redbot/core/bot.py Outdated Show resolved Hide resolved
jack1142 and others added 2 commits Jan 6, 2020
Co-Authored-By: Michael H <michael@michaelhall.tech>
@mikeshardmind mikeshardmind merged commit 474bb09 into Cog-Creators:V3/develop Jan 6, 2020
2 checks passed
@jack1142 jack1142 deleted the V3/reinstall_reqs branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants