Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CustomCom] Use humanize_list for iterable arguments #3277

Merged
merged 3 commits into from Jan 6, 2020
Merged

[CustomCom] Use humanize_list for iterable arguments #3277

merged 3 commits into from Jan 6, 2020

Conversation

zephyrkul
Copy link
Contributor

@zephyrkul zephyrkul commented Jan 6, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Some parameter attributes (like {#:Role.members}) return iterables, which can result in poor-looking CCs:
Screenshot

This applies humanize_list in such cases, resulting in more human-understandable CCs:
Screenshot

@zephyrkul zephyrkul requested a review from palmtree5 as a code owner Jan 6, 2020
@zephyrkul zephyrkul requested a review from Twentysix26 as a code owner Jan 6, 2020
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 6, 2020
@mikeshardmind mikeshardmind added the Type: Enhancement label Jan 6, 2020
@mikeshardmind mikeshardmind merged commit 45860ca into Cog-Creators:V3/develop Jan 6, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants