Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Downloader] Move author key handling to RepoJSONMixin, fix NameError #3285

Merged
merged 8 commits into from Jan 8, 2020

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Jan 8, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • Fix NameError in Downloader._filter_incorrect_cogs_by_names()
  • Move handling of author key in info.json to RepoJSONMixin

@jack1142 jack1142 requested a review from tekulvw as a code owner Jan 8, 2020
@jack1142 jack1142 requested a review from Twentysix26 as a code owner Jan 8, 2020
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 8, 2020
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

LGTM

@mikeshardmind mikeshardmind merged commit af859aa into Cog-Creators:V3/develop Jan 8, 2020
2 checks passed
@jack1142 jack1142 deleted the patch-4 branch Jan 13, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants