Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start making use of typehints for devs #3335

Merged
merged 2 commits into from Jan 13, 2020

Conversation

@mikeshardmind
Copy link
Member

mikeshardmind commented Jan 11, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

A lot of the bot's code is actually covered on type hints. It's not entirely enough for mypy, but lets start having these be seen by type analysis for people using that.

@mikeshardmind mikeshardmind added this to the Next Feature release milestone Jan 11, 2020
Copy link
Member

jack1142 left a comment

// Finally 😄
Might be good to add a comment in py.typed file why it's there (i.e. # Marker file for PEP 516), it wouldn't hurt and makes it more obvious why we have some random empty file inside package.
But it's just a preference so this PR is fine.

@mikeshardmind mikeshardmind merged commit ab2e87a into Cog-Creators:V3/develop Jan 13, 2020
2 checks passed
2 checks passed
Lint Python
Details
Travis CI - Pull Request Build Passed
Details
Drapersniper added a commit to Drapersniper/Red-DiscordBot that referenced this pull request Jan 16, 2020
* Start making use of typehints for devs

* changelog
@mikeshardmind mikeshardmind deleted the mikeshardmind:begin-typing branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.