Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Update licenseinfo command to conform with non-American English. #3460

Merged
merged 3 commits into from Feb 22, 2020
Merged

Conversation

Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Jan 27, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Update the licence command to confirm with non-American English and keep it inline with the colour/color command

…eep it inline with the `colour`/`color` command

Signed-off-by: Draper <27962761+Drapersniper@users.noreply.github.com>
@Drapersniper Drapersniper added Type: Enhancement QA: Needed Category: Bot Core labels Jan 27, 2020
@Drapersniper Drapersniper added this to the 3.3.1 milestone Jan 27, 2020
@Drapersniper Drapersniper requested a review from mikeshardmind Jan 27, 2020
@Drapersniper Drapersniper requested a review from tekulvw as a code owner Jan 27, 2020
Signed-off-by: Draper <27962761+Drapersniper@users.noreply.github.com>
@mikeshardmind mikeshardmind modified the milestones: 3.3.1, 3.3.2 Feb 5, 2020
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

You swapped en-US to an alias here. That needs to go back, the project default locale is en-US, and the shown command names should reflect this.

Aliases being displayed as well can be handled as a separate change to help, but our default view should be consistent across the project here.

@mikeshardmind mikeshardmind modified the milestones: 3.3.2, 3.3.3 Feb 14, 2020
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@jack1142 jack1142 merged commit 6c062ab into Cog-Creators:V3/develop Feb 22, 2020
5 checks passed
@jack1142 jack1142 modified the milestones: 3.3.3, 3.3.2 Feb 22, 2020
@Drapersniper Drapersniper deleted the non-us branch Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bot Core Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants