Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payday should store the last time it was used so it can be compared to the cooldown value rather than using a cooldown deco that won't reset if cooldown goes lower #3496

Merged
merged 4 commits into from Feb 14, 2020

Conversation

Hedlund01
Copy link
Contributor

@Hedlund01 Hedlund01 commented Feb 3, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Changes next_payday to last_payday. last_payday stores the latest time the command runned successfully, allows the command to dynamicly change with the PAYDAY_TIME variable, by checking if last_payday + PAYDAY_TIME >= current time.

Issue #3438

@jack1142 jack1142 added Type: Enhancement Type: Fix and removed Type: Enhancement labels Feb 3, 2020
Copy link
Contributor

@Drapersniper Drapersniper left a comment

.vs/slnx.sqlite This file isn't needed als Style is failing please make sure to run make reformat before committing

redbot/cogs/economy/economy.py Outdated Show resolved Hide resolved
redbot/cogs/economy/economy.py Outdated Show resolved Hide resolved
redbot/cogs/economy/economy.py Outdated Show resolved Hide resolved
redbot/cogs/economy/economy.py Outdated Show resolved Hide resolved
redbot/cogs/economy/economy.py Outdated Show resolved Hide resolved
redbot/cogs/economy/economy.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Drapersniper Drapersniper left a comment

.vs/Red-DiscordBot2/v16/.suo
.vs/slnx.sqlite
.vs/Red-DiscordBot2/config/applicationhost.config

These should be removed but other than this LGTM

@jack1142 jack1142 linked an issue Feb 4, 2020 that may be closed by this pull request
@Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Feb 9, 2020

Friendly ping on this, just missing the changes from the last review (Also please update the branch so that the test are completed)

Copy link
Contributor

@Drapersniper Drapersniper left a comment

LGTM

@jack1142 jack1142 added this to the 3.3.2 milestone Feb 11, 2020
@Drapersniper Drapersniper changed the title Issue [Economy] Payday #3438 Payday should store the last time it was used so it can be compared to the cooldown value rather than using a cooldown deco that won't reset if cooldown goes lower Feb 11, 2020
@mikeshardmind mikeshardmind merged commit 6ddaff6 into Cog-Creators:V3/develop Feb 14, 2020
5 checks passed
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants