Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecations in asyncio #3509

Merged
merged 5 commits into from Feb 5, 2020

Conversation

@mikeshardmind
Copy link
Contributor

mikeshardmind commented Feb 5, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

asyncio.get_event_loop is being deprecated (see bpo-39529)
Additionally, explictly passing a loop to certain asyncio objects and functions was deprecated as of 3.8

The correct usage with multiple event loops requires utilizing asyncio.call_coroutine_threadsafe and isn't something we utilize at all, but if anyone has used any of the changed utils incorrectly (by asyncio standards) they'll get a warning about this.

….get_event_loop()` is being deprecated
@mikeshardmind mikeshardmind requested a review from jack1142 Feb 5, 2020
@mikeshardmind mikeshardmind added this to the 3.3.1 milestone Feb 5, 2020
redbot/pytest/downloader.py Outdated Show resolved Hide resolved
Co-Authored-By: jack1142 <6032823+jack1142@users.noreply.github.com>
@mikeshardmind mikeshardmind merged commit 00cf395 into Cog-Creators:V3/develop Feb 5, 2020
5 checks passed
5 checks passed
Lint Python
Details
Tox - Tests
Details
Tox - Style
Details
Tox - Docs
Details
Tox - Postgres (3.8)
Details
@mikeshardmind mikeshardmind deleted the mikeshardmind:asyncio-is-fun branch Feb 5, 2020
kennnyshiwa pushed a commit to kennnyshiwa/BB-8-Bot that referenced this pull request Feb 6, 2020
* passing loop to certain things was deprecated. additionally, `asyncio.get_event_loop()` is being deprecated

* awesome, checks are functioning as intended

* fun with fixtures

* we can just stop misuing that anyhow

* Update redbot/pytest/downloader.py

Co-Authored-By: jack1142 <6032823+jack1142@users.noreply.github.com>

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.