Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make [p]announce send error message only when an actual errors occurs #3514

Merged
merged 2 commits into from Feb 6, 2020
Merged

Make [p]announce send error message only when an actual errors occurs #3514

merged 2 commits into from Feb 6, 2020

Conversation

trundlr
Copy link
Contributor

@trundlr trundlr commented Feb 6, 2020 •
edited

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Announce should only send an error message if an actual error occurs. Issue #3513

@trundlr trundlr requested a review from tekulvw as a code owner February 6, 2020 16:29
@Drapersniper Drapersniper linked an issue Feb 6, 2020 that may be closed by this pull request
!announce always sends a message to owners #3513
Closed
Drapersniper
Drapersniper suggested changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@Drapersniper Drapersniper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the previous comment

@Drapersniper Drapersniper self-assigned this Feb 6, 2020
@Drapersniper Drapersniper added this to the 3.3.2 milestone Feb 6, 2020
Drapersniper
Drapersniper approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@Drapersniper Drapersniper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kowlin Kowlin merged commit 8d73838 into Cog-Creators:V3/develop Feb 6, 2020
@Jackenmen Jackenmen changed the title Update announcer.py Make [p]announce send error message only when an actual errors occurs Feb 28, 2020
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kowlin Kowlin Kowlin approved these changes

@Drapersniper Drapersniper Drapersniper approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees

@Drapersniper Drapersniper

Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

!announce always sends a message to owners
4 participants
@trundlr @Kowlin @Drapersniper @Jackenmen