Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make [p]announce send error message only when an actual errors occurs #3514

Merged
merged 2 commits into from Feb 6, 2020
Merged

Make [p]announce send error message only when an actual errors occurs #3514

merged 2 commits into from Feb 6, 2020

Conversation

trundler-dev
Copy link
Contributor

@trundler-dev trundler-dev commented Feb 6, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Announce should only send an error message if an actual error occurs. Issue #3513

@trundler-dev trundler-dev requested a review from tekulvw as a code owner Feb 6, 2020
@Drapersniper Drapersniper linked an issue Feb 6, 2020 that may be closed by this pull request
Copy link
Contributor

@Drapersniper Drapersniper left a comment

as per the previous comment

@Drapersniper Drapersniper self-assigned this Feb 6, 2020
@Drapersniper Drapersniper added this to the 3.3.2 milestone Feb 6, 2020
Copy link
Contributor

@Drapersniper Drapersniper left a comment

LGTM

Kowlin
Kowlin approved these changes Feb 6, 2020
@Kowlin Kowlin merged commit 8d73838 into Cog-Creators:V3/develop Feb 6, 2020
5 checks passed
@jack1142 jack1142 changed the title Update announcer.py Make [p]announce send error message only when an actual errors occurs Feb 28, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants