Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands module] functools.partial support #3542

Merged
merged 3 commits into from Feb 12, 2020
Merged

[commands module] functools.partial support #3542

merged 3 commits into from Feb 12, 2020

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Feb 12, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

As the annotations are derived from the source function, using the source module and globals here is fine for functool partials.

@mikeshardmind mikeshardmind added Type: Enhancement Category: Command Module labels Feb 12, 2020
@mikeshardmind mikeshardmind added this to the 3.3.2 milestone Feb 12, 2020
Michael H added 2 commits Feb 12, 2020
Copy link
Member

@jack1142 jack1142 left a comment

LGTM

@mikeshardmind mikeshardmind merged commit c2143fd into Cog-Creators:V3/develop Feb 12, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Command Module Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants