Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer error when pages isn't made of embeds nor strings in menu() #3571

Merged
merged 2 commits into from Feb 21, 2020

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Feb 18, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Also adds better type hint for pages list

@jack1142 jack1142 added Type: Fix Category: Utility Functions labels Feb 18, 2020
@jack1142 jack1142 requested a review from Twentysix26 as a code owner Feb 18, 2020
@jack1142 jack1142 changed the title Add more clear error to menu() when passed pages list doesn't contain embeds nor strings Add clearer error when pages isn't made of embeds nor string in menu() Feb 18, 2020
@jack1142 jack1142 changed the title Add clearer error when pages isn't made of embeds nor string in menu() Add clearer error when pages isn't made of embeds nor strings in menu() Feb 18, 2020
@mikeshardmind mikeshardmind merged commit 5ee73cd into Cog-Creators:V3/develop Feb 21, 2020
5 checks passed
@mikeshardmind mikeshardmind added this to the 3.3.2 milestone Feb 21, 2020
@jack1142 jack1142 deleted the jack1142-patch-1 branch Feb 28, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Utility Functions Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants