Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Use new PyPI urls #3607

Merged
merged 3 commits into from Feb 28, 2020
Merged

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Feb 23, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

While pypi.python.org is may still be used in links from other PyPA documentation, etc, the default interface for browsing packages is pypi.org. The domain pypi.python.org now redirects to pypi.org, and may be disabled sometime in the future.

Source: https://packaging.python.org/guides/migrating-to-pypi-org/

@@ -310,7 +310,7 @@ class Core(commands.Cog, CoreLogic):
author_repo = "https://github.com/Twentysix26"
org_repo = "https://github.com/Cog-Creators"
red_repo = org_repo + "/Red-DiscordBot"
red_pypi = "https://pypi.python.org/pypi/Red-DiscordBot"
red_pypi = "https://pypi.org/pypi/Red-DiscordBot"
Copy link
Member

@Flame442 Flame442 Feb 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these links work, the actual location both the old and new link bring you to is https://pypi.org/project/Red-DiscordBot (pypi -> project). Should we link there instead?

Copy link
Member Author

@jack1142 jack1142 Feb 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually used to link to the project but rather as an API endpoint. This endpoint only works with url https://pypi.org/pypi/Red-DiscordBot/json, not with https://pypi.org/project/Red-DiscordBot/json

Kowlin
Kowlin approved these changes Feb 28, 2020
@jack1142 jack1142 changed the title Use new PyPI urls [Core] Use new PyPI urls Feb 28, 2020
@jack1142 jack1142 merged commit e8b975a into Cog-Creators:V3/develop Feb 28, 2020
5 checks passed
@jack1142 jack1142 deleted the V3/fix_pypi_urls branch Feb 28, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bot Core Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants