Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a SnowflakeList for Command disable instead of checks #5552

Merged
merged 8 commits into from May 17, 2023
Merged

Use a SnowflakeList for Command disable instead of checks #5552

merged 8 commits into from May 17, 2023

Conversation

PredaaA
Copy link
Member

@PredaaA PredaaA commented Jan 24, 2022

Description of the changes

This avoids having many checks in memory for commands disable handling. Instead uses SnowflakeList from discord.utils.

@PredaaA PredaaA mentioned this pull request Jan 24, 2022
Open
@phenom4n4n
Copy link
Contributor

Just tested, works well.

@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Type: Optimisation Situations where too much time is necessary to complete the task. Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. labels Dec 29, 2022
@Jackenmen Jackenmen modified the milestones: 3.5.0, 3.5.1 Dec 29, 2022
@Flame442 Flame442 modified the milestones: 3.5.0, 3.5.1 Apr 13, 2023
@flaree flaree merged commit f47d1df into Cog-Creators:V3/develop May 17, 2023
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label May 17, 2023
@PredaaA PredaaA deleted the feat/command-disable-no-checks branch May 17, 2023 20:44
@Jackenmen Jackenmen modified the milestones: 3.5.4, 3.5.3 Jun 19, 2023
@Jackenmen Jackenmen mentioned this pull request Jul 23, 2023
Merged
@Jackenmen Jackenmen removed the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jul 23, 2023
@Jackenmen Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaree flaree flaree approved these changes

Assignees

@flaree flaree

Labels
Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features. Type: Optimisation Situations where too much time is necessary to complete the task.
Projects
None yet
Milestone
3.5.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PredaaA @phenom4n4n @flaree @Jackenmen @Flame442