Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build_depend instead of depend #45

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Use build_depend instead of depend #45

merged 1 commit into from
Nov 21, 2021

Conversation

Jaeyoung-Lim
Copy link
Contributor

Problem Description
This PR fixes a build failure with the error as the following.

Error(s):
- The manifest of package "grpc" (with format version 1) must not contain the following tags: depend

This problem was caused by #44, where the <depend> flag is only available on the package manifest format 2 (https://www.ros.org/reps/rep-0140.html#adding-depend) and the package.xml format used in this package is still on format 1

@tomlankhorst FYI

@tkazik
Copy link

tkazik commented Nov 12, 2021

Nice catch, @Jaeyoung-Lim .
As an alternative, the maintainers could also consider migrating to format version 2 acc this guide.
Or directly to format version 3 for ros2 (details here).

@alexmillane
Copy link

Can confirm that this fixes our build over on ethz-asl/voxblox#379

@tomlankhorst
Copy link
Contributor

Thanks for the quick fix!

@Jaeyoung-Lim
Copy link
Contributor Author

Jaeyoung-Lim commented Nov 20, 2021

@BillWSY Any chance we can get this in? The current master is broken without this change

@BillWSY BillWSY merged commit ae85902 into CogRob:master Nov 21, 2021
@BillWSY
Copy link
Member

BillWSY commented Nov 21, 2021

Thanks a lot for your contributions!

@BillWSY
Copy link
Member

BillWSY commented Nov 21, 2021

Sorry I changed this PR to run_depend after approving the merge. There is already a duplicated build_depend. Please let me know if there is still any problem.

@Jaeyoung-Lim
Copy link
Contributor Author

@BillWSY Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants