Skip to content

paper(medcat): MedCAT 2 paper related scripts and documentation#526

Merged
mart-r merged 123 commits into
mainfrom
medcat-v2-paper-and-faster-linker-w-faster-gcv
Jun 9, 2026
Merged

paper(medcat): MedCAT 2 paper related scripts and documentation#526
mart-r merged 123 commits into
mainfrom
medcat-v2-paper-and-faster-linker-w-faster-gcv

Conversation

@mart-r

@mart-r mart-r commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

mart-r added 30 commits November 7, 2025 11:09

@alhendrickson alhendrickson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor one from me, could you make a README.md in the medcat-v2/paper folder? Super high level one that basically says run pip install somewhere, then get the required data following each data folder, then ./run_all_at_once.sh or whatever.

Just something that explains /paper folder from a dev perspective with this repo open, I get the paper itself will explain a lot.

@tomolopolis

Copy link
Copy Markdown
Member

looks good for paper result reproduction.
Can you confirm:

  • none of this is included in the install of the lib?
  • should any of these script runs be run in a GHA build?

@mart-r

mart-r commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author
  • none of this is included in the install of the lib?

Goot point! As of now, it would have. But I've added a MANIFEST.in to avoid that.

  • should any of these script runs be run in a GHA build?

That isn't really possible. Not only is there no availability of models that this would work (full models, embedding linker model) for or the data (MIMIC raw data, linking datasets) that this uses, even if it did, the entire thing might take longer than the 6h allocated to job runners.

@tomolopolis tomolopolis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah agreed - worth adding in the README what version of the lib that this was last tested with.
lgtm otherwise

@mart-r mart-r merged commit b8c07a0 into main Jun 9, 2026
23 checks passed
@mart-r mart-r deleted the medcat-v2-paper-and-faster-linker-w-faster-gcv branch June 9, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants