New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all Service Knot related classes deprecated. #428

Merged
merged 8 commits into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@tomaszmichalak
Contributor

tomaszmichalak commented Jul 11, 2018

Service Knot is replaced by Knot.x Data Bridge. We plan to remove the previous mechanism so we need to update all source code and documentation.

Description

The scope:

  • mark of the classes with deprecated and with a link to the migrated class
  • update the documentation

Motivation and Context

Replace Service Knot with Knot.x Data Bridge.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@Skejven

Please align version 1.3.1 or 1.3.2?
There are several occurrences of each version in javadocs.

@@ -23,8 +23,10 @@
import java.util.List;
/**
* Options describing how an ServiceAdapter will make connections with external HTTP services.
* @deprecated As of release 1.3.1, replaced by <a href="https://github.com/Knotx/knotx-data-bridge/blob/master/core/src/main/java/io/knotx/databridge/core/DataBridgeKnotOptions.java">DataBridgeKnotOptions</a>

This comment has been minimized.

@Skejven

Skejven Aug 13, 2018

Contributor

Version should be 1.3.2

@Skejven

Skejven Aug 13, 2018

Contributor

Version should be 1.3.2

This comment has been minimized.

@tomaszmichalak

tomaszmichalak Aug 13, 2018

Contributor

Fixed

@tomaszmichalak

tomaszmichalak Aug 13, 2018

Contributor

Fixed

Show outdated Hide outdated .../main/java/io/knotx/adapter/service/http/HttpServiceAdapterVerticle.java Outdated

tomaszmichalak and others added some commits Aug 13, 2018

@tomaszmichalak tomaszmichalak merged commit a35439e into master Aug 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tomaszmichalak tomaszmichalak deleted the feature/mark-service-knot-deprecated branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment