New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port unit and integration tests to JUnit 5 #432

merged 2 commits into from Sep 4, 2018


None yet
2 participants

tMaxx commented Sep 3, 2018


  • Switch from JUnit v4 to v5 for majority of unit, and all integration tests (excluded are knotx-adapter-* modules which are already a part of knotx-data-bridge; see Knotx/knotx-data-bridge#19)
  • Clean up unnecessary Maven test dependencies

Travis build will fail until Knotx/knotx-dependencies#6 and Knotx/knotx-junit5#2 are merged.

Some fixes may still be necessary

Motivation and Context

Part of ongoing work to switch to JUnit 5 in whole Knot.x project. See #417 for further references, scope, and motivation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@tMaxx tMaxx requested review from marcinczeczko, Skejven and tomaszmichalak and removed request for marcinczeczko Sep 3, 2018

@tomaszmichalak tomaszmichalak merged commit bc6cbf8 into master Sep 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tomaszmichalak tomaszmichalak deleted the feature/junit5-tests-ported branch Sep 4, 2018

@tMaxx tMaxx referenced this pull request Sep 4, 2018


JUnit 5 Support #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment