New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable different Vert.x Config stores types fix. #440

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@tomaszmichalak
Contributor

tomaszmichalak commented Sep 7, 2018

Bugfix for Vert.x Config stores other than the file store.

Description

We want to be able to define different Vert.x Config store types, not only file store.

Motivation and Context

It allows to define dynamic ports in configuration for tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@Skejven

Skejven approved these changes Sep 7, 2018

.forEach(store -> store.getJsonObject("config")
.put("path", resolveConfigPath(store.getJsonObject("config").getString("path"))));
.forEach(store -> {
if (FILE_STORE.equals(store.getString("type"))) {

This comment has been minimized.

@Skejven

Skejven Sep 7, 2018

Contributor

how about:

          .filter(store -> FILE_STORE.equals(store.getString("type")))
          .forEach(store -> store.getJsonObject("config")
              .put("path", resolveConfigPath(store.getJsonObject("config").getString("path"))));
@Skejven

Skejven Sep 7, 2018

Contributor

how about:

          .filter(store -> FILE_STORE.equals(store.getString("type")))
          .forEach(store -> store.getJsonObject("config")
              .put("path", resolveConfigPath(store.getJsonObject("config").getString("path"))));

@tomaszmichalak tomaszmichalak merged commit fde4491 into master Sep 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tomaszmichalak tomaszmichalak deleted the feature/different-configs-stores-fix branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment