Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/fragment processing failure handling #468
IMPLEMENTATION IN PROGRESS
Implementation of #466
Motivation and Context
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
I hereby agree to the terms of the Knot.x Contributor License Agreement.
Knots should not be able to modify the fallback. It is restricted to snippet.
Features implemented so far:
1. Simple blank fallback
2. Static markup fallback
create a fallback snippet with
3. Global blank fallback
to apply BLANK fallback to all snippets by default configure
4. Global fallback with custom markup
to apply custom markup fallback to all snippets by default:
5. fallback with custom FallbackStrategy
you can deliver your own class that will be fired by the assembler if given fragment fails
According to 5:
In that way our fallback strategy implementation should pass the flow to the next fallback. I thought about something similar to io.knotx.server.handler.knot.KnotEngineRoutingHandlerFactory.KnotxEngineHandler#handleRoute.
left a comment
Really good docs, thank you.
This code looks good to me.