Removed redundant defaultLocale cookie set #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmajano
added a commit
that referenced
this pull request
May 21, 2012
Removed redundant defaultLocale cookie set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both cfset cookie["DefaultLocale"] & cfcookie send the cookie in the response to the client so only one is needed. I chose cfcookie since it gives you more options and we may provide options in the future to persist this cookie for longer than the browser session.
Ben has a writeup about this behavior:
http://www.bennadel.com/blog/1913-Setting-ColdFusion-Cookies-With-CFCookie-vs-Cookie-Scope.htm