Colin Kelley
ColinDKelley

Organizations

@Invoca
Aug 19, 2016
ColinDKelley commented on pull request Invoca/write_xlsx#1
@ColinDKelley

Amazing sluething @deltaroe ! This is awesome. :)

Jul 27, 2016
@ColinDKelley

@jakesutton @eric-dowty It was bugging me that I was doing a linear search on the field_specs. Then I realized it's HashWithIndifferentAccess so ha…

Jul 27, 2016
@ColinDKelley
  • @ColinDKelley a30c8c2
    field_specs is a hash so use has_key?--it's much faster
Jul 27, 2016
@ColinDKelley
  • @ColinDKelley 11c4cf6
    Don't declare inheritance_column if already declared
Jul 14, 2016
ColinDKelley commented on pull request Invoca/rails#27
@ColinDKelley

and I'm betting that Bogdan was shooting in the dark That's a safe bet.

Jul 14, 2016
ColinDKelley commented on pull request Invoca/rails#26
@ColinDKelley

@omeedrabani Perfect.

Jul 14, 2016
ColinDKelley commented on pull request Invoca/rails#26
@ColinDKelley

@omeedrabani So do I understand that you have an override way to track rows read in active_table_set? I just want to make sure that we'll still hav…

Jul 11, 2016
@ColinDKelley
Jul 11, 2016
ColinDKelley merged pull request Invoca/hobo_fields#5
@ColinDKelley
Add varbinary to list of sql types that need to compare limit
1 commit with 1 addition and 1 deletion
Jul 11, 2016
ColinDKelley opened pull request Invoca/hobo_fields#5
@ColinDKelley
Add varbinary to list of sql types that need to compare limit
1 commit with 1 addition and 1 deletion
Jul 11, 2016
Jul 8, 2016
ColinDKelley commented on pull request Invoca/boyer_moore#2
@ColinDKelley

👍

ColinDKelley deleted branch enumerable at Invoca/boyer_moore
Jul 6, 2016
Jul 6, 2016
@ColinDKelley
  • @ColinDKelley 19fa8c1
    Merge pull request #4 from meineerde/fix/exceptions_and_false_values
  • @meineerde aa0002b
    Raise TypeError of a value in the chain doesn't support dig
  • 2 more commits »
Jul 6, 2016
ColinDKelley merged pull request Invoca/ruby_dig#4
@ColinDKelley
Raise appropriate exceptions and return false values
3 commits with 21 additions and 12 deletions
Jul 6, 2016
ColinDKelley commented on pull request Invoca/ruby_dig#4
@ColinDKelley

Sorry for the slow response. Looks good!

Jun 27, 2016
ColinDKelley commented on issue Invoca/ruby_dig#5
@ColinDKelley

Oh, thanks, I lost track of that PR but will try to check it out this week. -Colin On Mon, Jun 27, 2016 at 1:50 PM, Alexander Groß notifications@gi…

Jun 27, 2016
ColinDKelley commented on issue Invoca/ruby_dig#5
@ColinDKelley

I agree. I don't have the time to change this gem to be compatible, but if you'd like to do that I'd be happy to accept the PR. Or I can just yank …

Jun 27, 2016
ColinDKelley commented on issue Invoca/ruby_dig#5
@ColinDKelley

It's true. The Ruby 2.3 version of dig is sadly (IMO) useless because of this. You will get similar exceptions if you try to dig into an Array with …

Jun 23, 2016
ColinDKelley commented on pull request Invoca/rails#21
@ColinDKelley

👍

Jun 22, 2016
@ColinDKelley
Jun 22, 2016
ColinDKelley merged pull request Invoca/boyer_moore#1
@ColinDKelley
Implemented Enumerator contract
5 commits with 98 additions and 19 deletions
Jun 22, 2016
ColinDKelley commented on pull request Invoca/boyer_moore#1
@ColinDKelley

I was thinking about that, but I'd need to refactor to have an object wrapped around the result set in order to do that. I got as far as having Enu…

Jun 22, 2016
@ColinDKelley
Jun 22, 2016
@ColinDKelley
Jun 22, 2016
ColinDKelley opened pull request Invoca/boyer_moore#1
@ColinDKelley
Implemented Enumerable contract
4 commits with 74 additions and 19 deletions
Jun 22, 2016
@ColinDKelley
Implement Enumerator contract
Jun 22, 2016
@ColinDKelley
Implement Enumerator contract
4 commits with 74 additions and 19 deletions
Jun 22, 2016
@ColinDKelley
  • @ColinDKelley 992bf77
    Rename each back to search and remove find (since search.first does t…