Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing style of QStandardItem built-in checkbox #92

Closed
KcHNST opened this issue Apr 23, 2018 · 5 comments
Closed

Missing style of QStandardItem built-in checkbox #92

KcHNST opened this issue Apr 23, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@KcHNST
Copy link
Contributor

KcHNST commented Apr 23, 2018

Describe Your Environment

[Versions from your environment]

  • QDarkStyle: 2.5.3
  • OS: Win 7
  • Python: 3.6.5
  • PyQt: 5.10.1

Language

Python

Description / Steps to Reproduce

The built-in checkbox of QStandardItem does not used the styled checkbox whenever the check state is Qt::PartiallyChecked.

Actual Result

The problem checkbox shown among correctly styled checkboxes:

qstandarditemcheckbox

Expected Results / Proposed Result

The style should look like that of QCheckBox presumably?

qcheckbox

@KcHNST
Copy link
Contributor Author

KcHNST commented Apr 24, 2018

Closed due to not being customize-able using a stylesheet.

@KcHNST KcHNST closed this as completed Apr 24, 2018
@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented Apr 26, 2018

Reopening because I forget @aitormoreno actually found a solution in PR #67. I think he just forget the Indeterminate state. We should fix it.

@dpizetta
Copy link
Collaborator

I will check this as soon as possible, thanks

@KcHNST
Copy link
Contributor Author

KcHNST commented Apr 27, 2018

Something like this?

Idle:

QTreeView::indicator:indeterminate,
QListView::indicator:indeterminate {
    image: url(:/qss_icons/rc/checkbox_indeterminate.png);
}

Focus:

QTreeView::indicator:indeterminate:hover,
QTreeView::indicator:indeterminate:focus,
QTreeView::indicator:indeterminate:pressed,
QListView::indicator:indeterminate:hover,
QListView::indicator:indeterminate:focus,
QListView::indicator:indeterminate:pressed {
    image: url(:/qss_icons/rc/checkbox_indeterminate_focus.png);
}

@dpizetta
Copy link
Collaborator

dpizetta commented May 4, 2018

Hi @KcHNST , could you add a PR for this? I think it is correct. Try to check if it works in your app. Tks again!

@dpizetta dpizetta added this to the 2.5.4 milestone May 4, 2018
KcHNST added a commit to KcHNST/QDarkStyleSheet that referenced this issue May 8, 2018
Added image for the missing QTreeView/QListView undeterminated state, fix ColinDuquesnoy#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants