You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Simply copied for now. Two things that came to my mind:
Set self$path to private$path; this is taste, but one might prohibit direct access and work with setters/getters in the public interface to change the path with checks on the correctness/catching typos when changing the path etc.
For adding storage (cachem) and remote memoise + bank either of:
make Storage class a skeleton/interface/abstract class with (private) members themselves being R6 classes of the type that is now added (from qs) in Port storage class from odds #13 and provide access to the other classes (for cachem/memoise+bank) through this interface
or, alternatively, define 3 separate R6 classes, one for each task (i.e. skip the interface class)
Since 2. is a design thing, and I have no idea where this is going, let me know the direction @ColinFay , I am happy to help!
Activity
ilyaZar commentedon Mar 28, 2023
Simply copied for now. Two things that came to my mind:
self$pathtoprivate$path; this is taste, but one might prohibit direct access and work with setters/getters in the public interface to change the path with checks on the correctness/catching typos when changing the path etc.cachem) and remotememoise + bankeither of:Storageclass a skeleton/interface/abstract class with (private) members themselves being R6 classes of the type that is now added (from qs) in Port storage class from odds #13 and provide access to the other classes (for cachem/memoise+bank) through this interfaceSince 2. is a design thing, and I have no idea where this is going, let me know the direction @ColinFay , I am happy to help!