Skip to content

ASaDev, I want a storage mechanism #12

Open

Description

@ColinFay

Let's port of https://github.com/ColinFay/odds here.

With memory storage (cachem), disk storage (qs), and remote (memoise + bank)

Activity

  1. ilyaZar commented on Mar 28, 2023

    @ilyaZar
    Contributor

    Simply copied for now. Two things that came to my mind:

    1. Set self$path to private$path; this is taste, but one might prohibit direct access and work with setters/getters in the public interface to change the path with checks on the correctness/catching typos when changing the path etc.
    2. For adding storage (cachem) and remote memoise + bank either of:
      • make Storage class a skeleton/interface/abstract class with (private) members themselves being R6 classes of the type that is now added (from qs) in Port storage class from odds #13 and provide access to the other classes (for cachem/memoise+bank) through this interface
      • or, alternatively, define 3 separate R6 classes, one for each task (i.e. skip the interface class)

    Since 2. is a design thing, and I have no idea where this is going, let me know the direction @ColinFay , I am happy to help!

  2. self-assigned this
    on Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions