iOS App: Impress: Copy&Paste does not work

[smirta]

Describe the bug
copy & paste does not work at all. Wasn't working very well in previous 6.x.x versions either.

To Reproduce
Steps to reproduce the behavior:

1. select test in a text box or also a whole textbox
2. long press & select copy or copy in top bar if not grayed out
3. long press & paste in another textbox

Expected behavior
Contents gets copied.

Actual behavior
Nothing's copied.

iPad Pro

• iPad OS: 14.0.1
• Collabora Office 6.4.5

[tml1024]

Can reproduce with a fresh build from core:cp-6.4 + online:co-6-4. Possibly caused by presentation documents using special-case clipboard code written for the normal case of Collabora Online in a browser. Such is unneeded in the iOS app. (Copy and paste in text and spreadsheet documents seems to still work as expected.) Probably easy to fix.

[tml1024]

Note that the "Copy" button on the toolbar does work also in presentation documents. (But sure, the "Copy" in the context menu needs to work, too.)

[tml1024]

The root problem here seems to be in the C++ bits of Online or in core. When you invoke the Copy in the context menu, the JS bits do send the "uno .uno:Copy" message to the native code part. Which is good, the less JS debugging and investigation the better.

[tml1024]

On the other hand, it is slightly mysterious that the "Copy" button in the toolbar works then. As far as I understand, it very simply sends the "uno .uno:Copy" message.

[tml1024]

Hmm, the SfxDispatcher::Call_Impl() returns very early, in the:

if ( !rSlot.IsMode(SfxSlotMode::FASTCALL) && !rShell.CanExecuteSlot_Impl(rSlot) && !rShell.IsConditionalFastCall(rReq) )
        return;

[tml1024]

When .uno:Copy is dispatched from the context menu, all three parts of the above condition hold, and thus it returns early. When you use the button on the toolbar, only the first condition ("not fastcall") holds, and the code continues.

[tml1024]

For some reason, in the context menu case, in the DrawViewShell::GetMenuState () function (as called from SfxShell::CanExecuteSlot_Impl()), the line rSet.DisableItem( SID_COPY ); gets executed, but not in the toolbar button case.

[tml1024]

It is the pOlView->GetSelected().isEmpty() that returns true in the context menu case. Have been adding debugging output to try to figure out what it is that empties what editeng thinks is the selection here when you open the context menu.

[tml1024]

Would be interesting to know if this is broken in the Android app, too, @thebearon ?

[tml1024]

Suggested fix in https://gerrit.libreoffice.org/c/core/+/112261

[tml1024]

Fix committed to the cp-6.4 branch.