Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS only opens MSO documents #1509

Closed
oiselarius opened this issue Feb 19, 2021 · 6 comments
Closed

iOS only opens MSO documents #1509

oiselarius opened this issue Feb 19, 2021 · 6 comments
Labels
bug Something isn't working ios Specific to the Collabora Office iOS app, or to online accessed from i(Pad)OS devices

Comments

@oiselarius
Copy link

Describe the bug
All open doc and pdf formats are grayed out while MSO formats are highlighted to open.

To Reproduce
Steps to reproduce the behavior:

  1. Install Collabora on iPhone 12 Pro Max running iOS 14.4.
  2. Connect to my document folder in Google Drive
  3. Try to open files

Expected behavior
I thought Collabora was open document friendly

Actual behavior
doesn’t allow open format files to be opened

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)
N/A

Smartphone (please complete the following information)

  • Device: iPhone 12 Pro Max
  • OS: iOS 14.4
  • Browser: Firefox, Safari, or Edge
  • Version: 31.0

Additional context
Add any other context about the problem here.
@oiselarius oiselarius added bug Something isn't working unconfirmed labels Feb 19, 2021
@cornouws
Copy link
Collaborator

Thanks for reporting oiselarius!
Can you pls add if opening an odf file from the storage on the phone does work?

@oiselarius
Copy link
Author

oiselarius commented Feb 20, 2021 •
edited
Loading

If I transfer the file from cloud storage to the phone it seems to work. I don’t know why the same files stored on a cloud server won’t open.

edit: Collabora for iOS won’t open files on cloud servers other than iCloud. I use Google Drive but I also have OneDrive and DropBox and it won’t open them but if I pay for storage on iCloud it will open them.

@tml1024
Copy link
Contributor

tml1024 commented Mar 23, 2021 •
edited
Loading

Looking into this now. As far as I recall, other storage providers used to work just fine. There certainly is no intentional code in our app that would restrict it to open files from iCloud, or prevent ODF documents from being opened from Google Drive, so please avoid the insinuations ("I thought Collabora was open document friendly") thanks.

@tml1024
Copy link
Contributor

tml1024 commented Mar 23, 2021 •
edited
Loading

I just tried opening a .ods document from OneDrive and it worked just fine. (This is using the latest TestFlight build.)

@tml1024
Copy link
Contributor

tml1024 commented Mar 23, 2021

But yeah, for some reason all ODF documents in Google Drive are greyed out in the app. This is probably Google Drive's fault.

@tml1024
Copy link
Contributor

tml1024 commented Mar 23, 2021 •
edited
Loading

The fix for this seems to be to move the ODF entries for the ODF file types from the UTExportedTypeDeclarations section to the UTImportedTypeDeclarations section in the Info.plist. (Sadly the documentation for exact semantics of the Info.plist file leaves much to be desired.)

tml1024 pushed a commit that referenced this issue Mar 23, 2021
Tweak ODF types in Info.plist, making ODF documents openable from Goo…
b2afe02 
…gle Drive

Move the ODF entries for the ODF file types from the
UTExportedTypeDeclarations section to the UTImportedTypeDeclarations
section in the Info.plist. This, for some unclear reason, is necessary
to make ODF documents not appear greyed out for folders provided by
the Google Drive file provider extension. Sadly the documentation of
exact semantics of the Info.plist file leaves much to be desired.

This fixes #1509

Change-Id: I7ff35cf9f6c717d1579adc7a4d7350f78d7bee8e
Signed-off-by: Tor Lillqvist <tml@collabora.com>
@tml1024 tml1024 mentioned this issue Mar 23, 2021
Merged
6 tasks
tml1024 pushed a commit that referenced this issue Mar 23, 2021
@tml1024
Tweak ODF types in Info.plist, making ODF documents openable from Goo…
af418fb 
…gle Drive

Move the ODF entries for the ODF file types from the
UTExportedTypeDeclarations section to the UTImportedTypeDeclarations
section in the Info.plist. This, for some unclear reason, is necessary
to make ODF documents not appear greyed out for folders provided by
the Google Drive file provider extension. Sadly the documentation of
exact semantics of the Info.plist file leaves much to be desired.

This fixes #1509

Change-Id: I7ff35cf9f6c717d1579adc7a4d7350f78d7bee8e
Signed-off-by: Tor Lillqvist <tml@collabora.com>
@tml1024 tml1024 added ios Specific to the Collabora Office iOS app, or to online accessed from i(Pad)OS devices and removed unconfirmed labels Mar 23, 2021
@tml1024 tml1024 mentioned this issue Apr 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ios Specific to the Collabora Office iOS app, or to online accessed from i(Pad)OS devices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tml1024 @cornouws @oiselarius