Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spreadsheet jumps into begin if large text cells are edited #548

Closed
kadarpik opened this issue Nov 6, 2020 · 6 comments
Closed

spreadsheet jumps into begin if large text cells are edited #548

kadarpik opened this issue Nov 6, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@kadarpik
Copy link

kadarpik commented Nov 6, 2020

When we have 10+ rows doc with one column with very long text, every time I select the cell and try to edit it, the table
jumps into beginning. Or sometimes it does columnt jump too.

We use chrome latest browser and it happens in osx, Linux and windows.

To Reproduce
Steps to reproduce the behavior:

  1. craete a table with large text cells with 10+ lines inside each cell.
  2. Click on cell and then move into input bar on top of the sheet (where formula icons reside at the beinning)
  3. The text appears in input box as well as correct cell col and rown number
  4. sheet jumps into line one
  5. When I do the editing and press enter the sheet jumps back into correct position, i.e. to the next line

test done under nextcloud 16 docker image 6.4,chrome 86.0.4240.75 (64-bitine)
can not upload ods file unfortunately but I have attached an url for fownload.
https://avalik.3kgroup.ee/index.php/s/iSsZycB7ssAsEST
the link to the file must be downloaded and tested with collabora online, the site uses onlyoffice.

@kadarpik kadarpik added bug Something isn't working unconfirmed labels Nov 6, 2020
@kadarpik
Copy link
Author

kadarpik commented Nov 6, 2020

Does anyone know, in what module the scroll, jump decision is made ? It happens when insert mode comes on. The data entry field at top is in expanded state, i.e. not one line height.

@kadarpik
Copy link
Author

kadarpik commented Nov 8, 2020

correct name of the text intput bar is formula bar might be the code reference Control.FormulaBar.js

@shuhaowu
Copy link

shuhaowu commented Feb 26, 2021

I can trivially reproduce this:

  1. Create a new sheet
  2. Enter a number on that textbox (say 30).
  3. Convert it into a percent.
  4. Go back to the same textbox and try to enter another number.
  5. The moment you hit a number key while on that textbox, the screen jumps all the way to the right.

This is likely a HiDPI problem, when I turn my screen to 1080p, this is no longer an issue.

EDIT: seeing your description I'm not sure if it is the same issue, so I'm going to create a new one.

@kadarpik
Copy link
Author

kadarpik commented Feb 26, 2021 via email

@mmeeks
Copy link
Contributor

mmeeks commented Feb 26, 2021

I thought I'd fixed this with this - https://gerrit.libreoffice.org/c/core/+/110419 merged some time ago; but it seems I didn't.
The problem is (almost certainly) that the calc formula edit line at the top uses an 'EditEngine' which is 99% used as a document element, and this EditEngine emits events that make it seem like they come from the document - to much confusion.
I have a follow-on prototype patch that needs some more attention to tackle this locally.

Internal ticket: https://phabricator.collabora.com/T25979 =)

Thanks for filing!

@pedropintosilva
Copy link
Contributor

This was fixed with the following patches :

#1827
https://gerrit.libreoffice.org/c/core/+/113047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants