tdf#141217: Fix several keyboard shortcut problems on iOS #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Apple devices, shortcuts like Copy, Paste, etc use the Cmd key (also known as the ⌘ key), not the Ctrl key. We shouldn't check KeyboardEvent.ctrlKey but e.metaKey. Introduce a function _isCtrlKey that checks the proper property depending on platform. That Cmd-V still doesn't work for plan text put on the pasteboard by another app needs to be fixed in core. Change-Id: I4e8a05afaed0bde193d00a7ded52fcebf3536b5f Signed-off-by: Tor Lillqvist <tml@collabora.com>
6 tasks
tml1024
deleted the
private/tml/tdf-141217-Fix-several-keyboard-shortcut-problems-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple devices, shortcuts like Copy, Paste, etc use the Cmd key
(also known as the ⌘ key), not the Ctrl key. We shouldn't check
KeyboardEvent.ctrlKey but e.metaKey. Introduce a function _isCtrlKey
that checks the proper property depending on platform.
That Cmd-V still doesn't work for plan text put on the pasteboard by
another app needs to be fixed in core.
Change-Id: I4e8a05afaed0bde193d00a7ded52fcebf3536b5f
Signed-off-by: Tor Lillqvist tml@collabora.com
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay