Do the iOS font selection for the notebookbar in native iOS code #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we can use UIFontPickerViewController which gives acess also to fonst provided and registered by other third-party apps on iOS. These fonts are not available otherwise. They don't show up when vcl enumerates fonts in core. This patch is work in progress for #472 . This patch affects only the font name selection control in the notebookbar. On iOS this is now no longer a "combo box" (implemented by the external "select2" Javascript library, if I understand correctly), but a button that brings up a native iOS control). For now it is just a plain HTML button. It should ideally later be styled to fit better into the visual style of the notebookbar. Change-Id: Ic5e53cad09ffa8c99336dfed594337525909dc90 Signed-off-by: Tor Lillqvist <tml@collabora.com>
tml1024
deleted the
private/tml/Do-the-iOS-font-selection-for-the-notebookbar-in-nat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we can use UIFontPickerViewController which gives acess also
to fonst provided and registered by other third-party apps on iOS.
These fonts are not available otherwise. They don't show up when vcl
enumerates fonts in core.
This patch is work in progress for
#472 . This patch
affects only the font name selection control in the notebookbar. On
iOS this is now no longer a "combo box" (implemented by the external
"select2" Javascript library, if I understand correctly), but a button
that brings up a native iOS control). For now it is just a plain HTML
button. It should ideally later be styled to fit better into the
visual style of the notebookbar.
Change-Id: Ic5e53cad09ffa8c99336dfed594337525909dc90
Signed-off-by: Tor Lillqvist tml@collabora.com
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay