Set the checked state of the FreezePanes item #5598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropintosilva
approved these changes
Dec 15, 2022
|
the failed test ran without issues locally |
|
@GulsahKose please rebase, the cypress was fixed on master. |
To show a checkmark for "Freeze Rows and Columns" item on hamburger menu, we have to set "checked" propery of the item according to uno command's status. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: Icfc2ac07a84ed8a843b3bb8b2fe4c75de8ad9233
GulsahKose
force-pushed
the
freezecheck
branch
from
860d459
to
01ef84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show a checkmark for "Freeze Rows and Columns" item on hamburger menu, we have to set "checked" propery of the item according to uno command's status.
Signed-off-by: Gülşah Köse gulsah.kose@collabora.com
Change-Id: Icfc2ac07a84ed8a843b3bb8b2fe4c75de8ad9233
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay