Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vex-overlay in admin console when Wsd shutdown #604

Merged
merged 1 commit into from Nov 26, 2020

Conversation

Rash419
Copy link
Contributor

@Rash419 Rash419 commented Nov 11, 2020

Signed-off-by: Rash419 rasheshpadia419@gmail.com
Change-Id: Ifcf259aee446196cc6e8269a540a6514e628e4a8

Screenshot from 2020-11-11 20-18-16

edit - Message has been updated to "Server has been shutdown please reload the page"

Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the message is miss leading. WSD cannot be reloaded on click, it requires WSD to restart

@lpranam
Copy link
Member

lpranam commented Nov 12, 2020

Also, commit message is not descriptive!

@Rash419 Rash419 force-pushed the indication-admin-console branch 2 times, most recently from f30ace3 to 1437026 Compare November 16, 2020 12:44
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any many files in many lines you have added trailing white spaces. Please remove that. You can use IDE settings to remove that easily and those settings will save you in future from such unnecessary changes too. :)

@Rash419
Copy link
Contributor Author

Rash419 commented Nov 16, 2020

check now , and if it there there can you tell me which line!!??

@Rash419 Rash419 force-pushed the indication-admin-console branch 2 times, most recently from a6ecad5 to 20a68d2 Compare November 16, 2020 13:31
@Rash419 Rash419 force-pushed the indication-admin-console branch 5 times, most recently from b67580c to acc5bcd Compare November 16, 2020 15:42
Signed-off-by: Rash419 <rasheshpadia419@gmail.com>
Change-Id: I16f9a2a55b7b17fe10ae14266c7db574bd2751ac
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lpranam lpranam merged commit 725cbe6 into CollaboraOnline:master Nov 26, 2020
@mrkara
Copy link
Member

mrkara commented Nov 26, 2020

@Rash419 Thank you! Keep up the good work! 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indication in the Admin console when the daemon shuts down
3 participants