New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check in FromDbConverter and ToDbConverter #431

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@asherber
Collaborator

asherber commented Dec 1, 2017

Support for value converter attribute in #408 appears to be missing two null checks in code added to ConventionMapper.cs. This was causing queries into dynamic objects to throw an exception, as reported in #415 and #430.

I added the null checks, and the examples in the referenced issues work fine now. All existing unit tests also pass. Possibly some further testing is needed before releasing.

@pleb pleb merged commit e523b6c into CollaboratingPlatypus:development Dec 4, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment