New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to register and retrieve custom providers #449

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
2 participants
@asherber
Collaborator

asherber commented Apr 10, 2018

Addresses #447

This is a first pass at the sort of thing I had in mind; I'm interested to hear feedback. What I'm envisioning is that rather than the end user needing to know how to correctly register a custom provider (i.e., what initialStrings to use), the provider could just implement its own static Register() method to do the work.

It is intentional that you can register more than one string for a provider. This is because one custom provider I'm working on for a third-party database has a provider name of Foo.Data.Provider, but the other types are called BarConnection and BarFactory.

I was also thinking about a more complicated and more powerful solution, but it would require a breaking change (new method on IProvider).

@pleb pleb merged commit ee93e6f into CollaboratingPlatypus:development Apr 11, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment