Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for provider initialization sequence in fluent constructor #508

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@asherber
Copy link
Collaborator

asherber commented Mar 11, 2019

There was something missing with #499 -- if you pass in a connection, you could also pass in a provider type, to override what the connection wants to use, but you couldn't pass in a provider name. This PR fixes that and refactors the initialization code a little to be cleaner and more uniform.

@asherber asherber requested a review from pleb Mar 11, 2019

@pleb pleb merged commit 2018349 into CollaboratingPlatypus:development Mar 12, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.