Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test demonstrating defect generating sql Count #535

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@butulia
Copy link
Contributor

commented May 16, 2019

A integration test to view the defect comment in this issue: #534

butulia added some commits May 16, 2019

Changed generation of SQL count statment in PagingHelper.SplitSQL met…
…hod to contemplate "Group by" in SQL statment
@pleb

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Thanks for the PR @butulia. I’ll take a look at this soon

@pleb

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@butulia thanks for the PR. I'll merge this soon.

I would like to add a few more tests for the paging API before I merge this to ensure we don't accidentally introduce a little regression.

@butulia

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

Perfect!!! The companions of @promatcloud are available for any problem you may encounter

@pleb pleb merged commit 96639bd into CollaboratingPlatypus:development Jun 11, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.