Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update should return 0 when columns is empty #552

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@asherber
Copy link
Collaborator

commented Sep 26, 2019

Fixes #551

@pleb I can also backport the changes to v5 if you want.

@pleb pleb merged commit a562455 into CollaboratingPlatypus:development Sep 26, 2019
1 check failed
1 check failed
continuous-integration/appveyor/pr AppVeyor build failed
Details
@pleb

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

I wouldn't worry about backporting ;)

@asherber

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

Should I note in the original issue that the fix won't be backported, and the OP can upgrade to v6 and still use his generated files?

@pleb

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

@asherber I've replied to OP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.