Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install/update game when using "open -p" / start game after install #422

Merged
merged 10 commits into from
Mar 14, 2024

Conversation

gablm
Copy link
Member

@gablm gablm commented Mar 7, 2024

This PR adds the ability for the "open" argument to update/install the game after being used if used with the option "--play" as well as allowing .

Some things note-worthy:

  • Even if the region is changed the game will start after the background download is done.
  • Using "open -p" when the target region is already installing/updating will make it open automatically when the process in question ends.
  • All dialogs will still be shown, as if the Download/Update Button was clicked
  • The "start after install" option can also be selected from within a Dialog, although I'm not really sure about the current UI design

Suggested by mieneko in https://discord.com/channels/1116150300324139131/1204244982731513856

@gablm gablm added Enhancement New feature or request Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Mar 7, 2024
@gablm gablm requested a review from a team March 7, 2024 17:47
@gablm gablm self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@gablm gablm changed the title Auto install/update game when using "open -p" Ability to start game after install Mar 12, 2024
@gablm gablm changed the title Ability to start game after install Auto install/update game when using "open -p" / start game after install Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Collaborator

@Cryotechnic Cryotechnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, still need to test this at home on my end, but you're missing a couple of localizable strings in the dialog, would be nice if we could expose those.

Copy link
Member

@neon-nyan neon-nyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code seems okay for me with some additional review as below:

@bagusnl bagusnl mentioned this pull request Mar 13, 2024
2 tasks
Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed, all okay overall!

@gablm gablm requested a review from bagusnl March 13, 2024 17:59
Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on me~

Copy link
Collaborator

@Cryotechnic Cryotechnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@neon-nyan neon-nyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appro🅱️e the changes

@gablm gablm merged commit 256b0dd into main Mar 14, 2024
4 checks passed
@gablm gablm deleted the open-upd-support branch March 14, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI/UX Issue labeled for User Interface/eXperience related issue Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants