Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode slimscroll options. #1605

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@ADmad
Copy link
Contributor

ADmad commented Aug 9, 2017

No description provided.

@almasaeed2010

This comment has been minimized.

Copy link
Contributor

almasaeed2010 commented Oct 26, 2017

We'll need a way to pass these options instead of just removing them. Maybe we can introduce slimscroll options to the layout plugin.

@ADmad

This comment has been minimized.

Copy link
Contributor Author

ADmad commented Oct 26, 2017

Yes introducing options for slimscroll would be the right way but until then removing these hard coded values at least allows one to set required styling through css.

@almasaeed2010

This comment has been minimized.

Copy link
Contributor

almasaeed2010 commented Oct 26, 2017

I should test how it would look like with the those options first. Will get back to you soon.

Thanks

@almasaeed2010 almasaeed2010 merged commit 5339340 into ColorlibHQ:master Oct 26, 2017

@almasaeed2010

This comment has been minimized.

Copy link
Contributor

almasaeed2010 commented Oct 26, 2017

doesn't seem to have a major effect by default

@ADmad

This comment has been minimized.

Copy link
Contributor Author

ADmad commented Oct 26, 2017

To me slimscroll's default scrollbar handle seems much better than the tiny 3px currently set 🙂

@ADmad

This comment has been minimized.

Copy link
Contributor Author

ADmad commented Oct 26, 2017

3px is way too small and rgba(0,0,0,0.2) too light for usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.