Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JS comment for better parsing #1693

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@defro
Copy link
Contributor

defro commented Oct 16, 2017

Hello @almasaeed2010
Thanks to share your incredible work and so nice admin theme.

I need to parse your html files for my PHP project but I have one problem when I met comment of this style: increaseArea: '20%' // optional
Because my parser remove whitespace so I got something like this: increaseArea: '20%' // optional});});</script>

With my changes submitted I will got something like that: increaseArea: '20%' /* optional */});});</script>

Regards,
Joël

@almasaeed2010 almasaeed2010 merged commit b98b591 into ColorlibHQ:master Oct 26, 2017

@defro

This comment has been minimized.

Copy link
Contributor Author

defro commented Oct 30, 2017

Many thanks @almasaeed2010 !

@almasaeed2010

This comment has been minimized.

Copy link
Contributor

almasaeed2010 commented Oct 30, 2017

No problem!

For future reference though, the minifying script should remove all comments before minification. Just in case (and this is likely) we go back to using the // style, you need to make sure your minification script does that.

Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.