-
Notifications
You must be signed in to change notification settings - Fork 6
Cannot read property 'names' of null #1
Comments
Seems like it happens when |
Yes, it's caused by the source maps. I've just pushed the basic support for them to the master, so you can use (or at least try to use…) the plugin straight from GH: npm install Comandeer/rollup-plugin-babili However the support for source maps is still very buggy and it'll probably fail on any more complex ES6 code. |
Same error with the version from master 😢 |
This is the branch where I'm trying to use this plugin, maybe it can help. https://github.com/FezVrasta/popper.js/tree/v1-dev-babili-plus-jsnext |
With alpha3 I get:
No idea why the result is different from when I used the GitHub URL... |
Sorry, I've forgot that I don't have the If it still won't work, you could – as a workaround – use Babili in Rollup using rollup-plugin-babel with babili preset in a similar manner as I'm doing at the moment. The only issue with such approach is the fact that Rollup is minifying every file separately, not the whole bundle (and that's why I'm trying to create this plugin). |
Thanks for the reply. I'm aware of the other method but I don't like the result. Right now I'm simply running babili via command line to get the best result. If you could fix this plugin it would be so much better tho! 🔥 |
Strangely enough the issue seems to be present only when bundling to the UMD format. When bundling to the ES format, everything is working fine. |
It seems more like bug in rollup, not the plugin itself. I'll investigate it further. |
Thank you, no rush by me. Once the plugin is ready I'll be happy to switch to it tho 🙂 |
I've added simple workaround for it and published in v1.0.0 of plugin. I hope that it will work now. |
This still occurs. See e.g. github.com/knockout/tko – running
|
I cannot reproduce this issue, both with local installation of rollup 0.41.6 and with global one. What version of rollup do you have installed? Because this issue is reproducible only on <0.41.5. |
Thanks, that was indeed the issue! |
This is what I get when I try to use this plugin:
The text was updated successfully, but these errors were encountered: