From f860308890c170f8604cabf9f76ac28837955eaf Mon Sep 17 00:00:00 2001 From: just1103 Date: Sun, 11 Feb 2024 00:21:41 +0900 Subject: [PATCH] fixed memory leak with PassthroughRelay --- Sources/Relays/PassthroughRelay.swift | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Sources/Relays/PassthroughRelay.swift b/Sources/Relays/PassthroughRelay.swift index f6e1231..555e706 100644 --- a/Sources/Relays/PassthroughRelay.swift +++ b/Sources/Relays/PassthroughRelay.swift @@ -74,6 +74,7 @@ private extension PassthroughRelay { func forceFinish() { self.sink?.shouldForwardCompletion = true self.sink?.receive(completion: .finished) + self.sink = nil } func request(_ demand: Subscribers.Demand) { @@ -81,7 +82,7 @@ private extension PassthroughRelay { } func cancel() { - sink = nil + forceFinish() } } }