Skip to content

🐛 FIX: enqueue dependencies for WP5. (#107)#110

Merged
ahmadawais merged 1 commit into
CommandCodeAI:masterfrom
maximebj:master
Nov 29, 2018
Merged

🐛 FIX: enqueue dependencies for WP5. (#107)#110
ahmadawais merged 1 commit into
CommandCodeAI:masterfrom
maximebj:master

Conversation

@maximebj
Copy link
Copy Markdown

I've updated the dependencies on enqueue functions in order to make it work with WP5 RC.

Styles are now loading well.

It's my first PR, please double-check my work
Also, I'm waiting an answer from the official Gut staff to be sure than theses dependencies are the right ones : maybe I'll publish another one soon, but right now the issue is fixed

The documentation about this is on wp.org is 404.

@maximebj
Copy link
Copy Markdown
Author

Confirmed by Youknowriad

So, basically dependencies are subject to change from a project to another, according to the needs. But this configuration is the most common to work everywhere

@ahmadawais
Copy link
Copy Markdown
Member

Glad that you got confirmation. Let me have a look at it.

@ahmadawais
Copy link
Copy Markdown
Member

Looks like the dependency for wp-editor was already there in the template but this PR fixes the examples.

Copy link
Copy Markdown
Member

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥

@ahmadawais ahmadawais merged commit 2946d04 into CommandCodeAI:master Nov 29, 2018
@ahmadawais
Copy link
Copy Markdown
Member

@maximebj welcome to CGB as a core contributor 👍

Also, I just pushed docs update the docs look much better now for the same files you edited.

@maximebj
Copy link
Copy Markdown
Author

maximebj commented Nov 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants