🐛 FIX: enqueue dependencies for WP5. (#107)#110
Merged
Conversation
Author
|
Confirmed by Youknowriad So, basically dependencies are subject to change from a project to another, according to the needs. But this configuration is the most common to work everywhere |
Member
|
Glad that you got confirmation. Let me have a look at it. |
Member
|
Looks like the dependency for |
Member
|
@maximebj welcome to CGB as a core contributor 👍 Also, I just pushed docs update the docs look much better now for the same files you edited. |
Author
|
Thanks ! I changed the examples but also the main CSS : it called wp-blocks
but it should call wp-editor.
That's the main purpose of this PR (update examples is a bonus)
With the right dependency CSS is now loading again
Le jeu. 29 nov. 2018 à 16:54, Ahmad Awais ⚡️ <notifications@github.com> a
écrit :
@maximebj <https://github.com/maximebj> welcome to CGB as a core
contributor 👍
Also, I just pushed docs update the docs look much better now for the same
files you edited.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<ahmadawais/create-guten-block#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABs-kdKKYX06f00d7lPqgSwTj9FcH25lks5u0AMygaJpZM4Y5pkx>
.
--
*Maxime BERNARD-JACQUET*
Entrepreneur Web, Expert WordPress
*maxime@dysign.fr* <maxime@dysign.fr>
|
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the dependencies on enqueue functions in order to make it work with WP5 RC.
Styles are now loading well.
It's my first PR, please double-check my work
Also, I'm waiting an answer from the official Gut staff to be sure than theses dependencies are the right ones : maybe I'll publish another one soon, but right now the issue is fixed
The documentation about this is on wp.org is 404.