Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Update index.js #289

Merged
merged 1 commit into from Mar 21, 2020
Merged

Update index.js #289

merged 1 commit into from Mar 21, 2020

Conversation

abusarimhindi
Copy link
Contributor

Updating for ur.js

@abusarimhindi
Update index.js
4372170 
Updating for ur.js
MichaelKohler
MichaelKohler approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@MichaelKohler MichaelKohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@abusarimhindi
Copy link
Contributor Author

Dear @MichaelKohler, I am not expert in coding and don't know any coding language, I came on GitHub to create pull request for my Urdu language, but I failed to create this, getting errors, and I couldn't understand where I am wrong.

For Urdu language limitation of 14 words is a problem, we need approx 25 words for a complete meaningful sentence.

I request you to please help me to create this PR.

@MichaelKohler
Copy link
Member

The error here is expected, as the rest of the work is in another Pull Request. This is all good :)

@abusarimhindi
Copy link
Contributor Author

abusarimhindi commented Jan 24, 2020 •
edited

When it will be merged? I am waiting for approval of my request. I want to start sentence collection work. Please clear the problem of this PR, if any.

@MichaelKohler MichaelKohler merged commit 87335c1 into common-voice:master Mar 21, 2020
@MichaelKohler
Copy link
Member

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelKohler MichaelKohler MichaelKohler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abusarimhindi @MichaelKohler