Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This patch fixes misuse of
FBOUNDP
which is used to determine if a slot is existing and bound in the object, but only can be used to check if a symbol is bound to a function. The incorrect use makes codex unusable.Also, there is a possibility that I missed something and there are more places in
src/macro.lisp
where unbound slots can be accessed. But I checked with my libraries which use codex for documentation and all works fine.And also, It can be good idea to refactor your code and avoid use of
SLOT-EXISTS-P
andSLOT-BOUNDP
completely using a generic function for collecting rows for the table and specific methods for each node class like so: