Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IPFS Data Accessor #783

Closed
fuubi opened this issue Jun 22, 2021 · 5 comments
Closed

feat: add IPFS Data Accessor #783

fuubi opened this issue Jun 22, 2021 · 5 comments
Assignees

Comments

@fuubi
Copy link

fuubi commented Jun 22, 2021

I implemented an additional data accessor (see feat/ipfs-accessor) that uses the IPFS network as an underlying persistency layer. Have a look at this paper for further details.

I am wondering if there is an interest in integrating the new accessor to the main codebase. I definitely have to reactivate the pre-commit hook that I disabled. Then the contribution must be refactored, the config files must be revised, and we might have a discussion if and how the IPFS Content Identifiers (CID) should be exposed. In general, it would be nice to get some feedback on how to proceed.

Some notes on how to start the server:

git checkout feat/ipfs-accessor
npm i 
# Edit the default ipfs data folder file path (default: /tmp/solid-ipfs1 ) 
vim config/presets/storage/backend/storage-ipfs.json
# Start the server
node ./bin/server.js -c config/config-ipfs.json -f /
@fuubi fuubi changed the title feat: added IPFS Data Accessor feat: add IPFS Data Accessor Jun 22, 2021
@RubenVerborgh
Copy link
Member

@fuubi That's amazing, really great.

As you know, CSS has been explicitly designed to allow easy integration of external modules. This seems like an excellent case to put this into practice.

I propose to publish this as a separate package, like I've for instance published solid-hue. You could add the example configuration there, and/or we could add it to the recipes. That would work really well.

We're about to publish the next CSS version, which has some changes to config structure, so you might want to keep an eye on that.

Let me know if you have any questions regarding the packaging of your module!

@fuubi
Copy link
Author

fuubi commented Jul 2, 2021

@RubenVerborgh Thank you.

I like the idea of publishing it as a separate package and adding the configuration to the recipes.
Great! Then I will go with the newest version.

Actually, yes! I have some troubles while configuring the module.
I created a css-demo-module to start simple. Unfortunately, it does not work yet.
Components.js seems to load the configuration, but then it throws an error as it can not find the module.

@RubenVerborgh
Copy link
Member

@fuubi Are you using the same package structure as in solid-hue? And have he Components.js files been generated?
I'd suggest copy/pasting your code into solid-hue for a quick test.

@fuubi
Copy link
Author

fuubi commented Jul 7, 2021

@RubenVerborgh I actually took solid-hue as a basis, but not the newest version. Instead, I used the first commit of solid-hue. Anyway, by using the current version together with the default config of v.0.8.1 it worked.

The demo/starter repo now also uses the latest CSS version.

@RubenVerborgh
Copy link
Member

Great news! I will update solid-hue to CSS v1.x sometime soon.

I'll close this issue; feel free to make a PR to this repo or the recipes to add in IPFS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants