Skip to content

Conversation

@joachimvh
Copy link
Member

Also closes #14 as an extra bonus

@joachimvh joachimvh requested a review from RubenVerborgh August 8, 2022 12:00
Copy link

@jeff-zucker jeff-zucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cloned 5.0, cut and pasted the new mashlib recipe config and tried to run the server. Got :

Could not build the config files from /home/jeff/Dropbox/Web/solid/css/mashlib-5-0-config.json
Cause: Error while parsing file "/home/jeff/Dropbox/Web/solid/css/mashlib-5-0-config.json": Unexpected STRING("css:config/util/logging/winston.json") in state COMMA

@joachimvh
Copy link
Member Author

@jeff-zucker not sure what the cause would be. Is this a branch you already had on which you pulled the latest updates? Did you do an npm ci afterwards? Version 5 comes with a new version of components.js which might explain that error if it wasn't updated.

I just tried again with the following steps in my local repository on the main branch:

  1. npm ci
  2. Copy the mashlib config into mashlib.json
  3. npm start -- -c mashlib.json -f .data

Which causes the server to start as expected. (And everything crashes if I try to browse to the server since I didn't install the required mashlib dependency in the steps above).

@jeff-zucker
Copy link

Yes, it must have been an artifact of a previous install. I started in a fresh folder and the following led to a working 5.0.0 server with mashlib as the front-end :

git clone https://github.com/CommunitySolidServer/CommunitySolidServer.git      
cd CommunitySolidServer                                                         
npm install --save mashlib                                                      
npm ci                                                                          
wget https://raw.githubusercontent.com/CommunitySolidServer/Recipes/v5.0.0/mashlib/config-mashlib.json                                                         
npm start -- -c config-mashlib.json -f .data          

@RubenVerborgh RubenVerborgh merged commit 3d1ab4b into main Aug 17, 2022
@RubenVerborgh RubenVerborgh deleted the v5.0.0 branch August 17, 2022 16:55
@RubenVerborgh
Copy link
Member

Great, thanks! Tested and confirmed working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update for https://github.com/CommunitySolidServer/Recipes

4 participants