diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2365f2012..eae3db033 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,13 +36,16 @@ Please see our [Code of Conduct](https://dotnetfoundation.org/code-of-conduct). As should be clear by now: we assume everyone tries to do their best, everyone should be treated with respect and equally. -In the unfortunate event that doesn't happen, please feel free to report it to any of the team members or reach out to [Gerald](maillo:gerald.versluis@microsoft.com) directly. +In the unfortunate event that doesn't happen, please feel free to report it to any of the team members or reach out to [Gerald](mailto:gerald.versluis@microsoft.com) directly. We will take appropriate actions and measures if necessary. ## Prerequisites -You will need to complete a Contribution License Agreement before any pull request can be accepted. Complete the CLA at https://cla.dotnetfoundation.org/. This will also be triggered whenever you open a PR and the link should guide you through it. +1. Install latest stable [.NET SDK](https://dotnet.microsoft.com/en-us/download) +1. Install .NET MAUI workloads (we recommend using Visual Studio installer) + +> You will need to complete a Contribution License Agreement before any pull request can be accepted. Complete the CLA at https://cla.dotnetfoundation.org/. This will also be triggered whenever you open a PR and the link should guide you through it. ## Reporting a bug diff --git a/Directory.Build.props b/Directory.Build.props index 585980c8b..f8fd1d1de 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,6 +1,7 @@  + net7.0 false latest @@ -26,8 +27,11 @@ CS1592: Badly formed XML in included comments file CS1598: XML parser could not be loaded. The XML documentation file will not be generated. CS1658: Identifier expected; 'true' is a keyword - CS1734: XML comment has a paramref tag, but there is no parameter by that name --> - nullable,CS0419,CS1570,CS1571,CS1572,CS1573,CS1574,CS1580,CS1581,CS1584,CS1589,CS1590,CS1592,CS1598,CS1658,CS1734 + CS1734: XML comment has a paramref tag, but there is no parameter by that name + MA0001: Don't define public events in NSObject subclasses + MA0002: Don't declare members in NSObject subclasses unless they are WeakReference, WeakReference, or Value types + MA0003: Don't subscribe to events inside NSObject subclasses unless it's your event (via this.MyEvent) or inherited from a base type, or the method is static --> + nullable,CS0419,CS1570,CS1571,CS1572,CS1573,CS1574,CS1580,CS1581,CS1584,CS1589,CS1590,CS1592,CS1598,CS1658,CS1734,MA0001,MA0002,MA0003 diff --git a/Directory.Build.targets b/Directory.Build.targets index 46d5afffd..a16476c2f 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -1,24 +1,24 @@  - + - + - + - + diff --git a/global.json b/global.json index 6c8b056ba..ccd059ad5 100644 --- a/global.json +++ b/global.json @@ -1,7 +1,7 @@ { "sdk": { "version": "7.0.200", - "rollForward": "latestMajor", + "rollForward": "latestFeature", "allowPrerelease": false } } diff --git a/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj b/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj index 0dd52648b..549161162 100644 --- a/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj +++ b/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj @@ -1,9 +1,9 @@ - + - net7.0-ios;net7.0-android;net7.0-maccatalyst - $(TargetFrameworks);net7.0-windows10.0.19041.0 - $(TargetFrameworks);net7.0-tizen + $(NetVersion)-ios;$(NetVersion)-android;$(NetVersion)-maccatalyst + $(TargetFrameworks);$(NetVersion)-windows10.0.19041.0 + $(TargetFrameworks);$(NetVersion)-tizen Exe true true @@ -42,6 +42,7 @@ + @@ -49,7 +50,7 @@ - + @@ -83,4 +84,4 @@ maccatalyst-arm64;maccatalyst-x64 - + \ No newline at end of file diff --git a/samples/CommunityToolkit.Maui.Sample/Pages/Essentials/SpeechToTextPage.xaml b/samples/CommunityToolkit.Maui.Sample/Pages/Essentials/SpeechToTextPage.xaml index 1d78bf18a..d864224ce 100644 --- a/samples/CommunityToolkit.Maui.Sample/Pages/Essentials/SpeechToTextPage.xaml +++ b/samples/CommunityToolkit.Maui.Sample/Pages/Essentials/SpeechToTextPage.xaml @@ -30,7 +30,7 @@ diff --git a/samples/CommunityToolkit.Maui.Sample/Pages/Views/AvatarView/AvatarViewRatingPage.xaml b/samples/CommunityToolkit.Maui.Sample/Pages/Views/AvatarView/AvatarViewRatingPage.xaml index 5429f4211..86086f8e0 100644 --- a/samples/CommunityToolkit.Maui.Sample/Pages/Views/AvatarView/AvatarViewRatingPage.xaml +++ b/samples/CommunityToolkit.Maui.Sample/Pages/Views/AvatarView/AvatarViewRatingPage.xaml @@ -53,8 +53,6 @@ - - @@ -66,7 +64,7 @@ Grid.Column="0" HeightRequest="48" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="1" WidthRequest="48" /> @@ -74,7 +72,7 @@ Grid.Column="1" HeightRequest="48" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="2" WidthRequest="48" /> @@ -82,7 +80,7 @@ Grid.Column="2" HeightRequest="48" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="3" WidthRequest="48" /> @@ -90,7 +88,7 @@ Grid.Column="3" HeightRequest="48" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="4" WidthRequest="48" /> @@ -98,7 +96,7 @@ Grid.Column="4" HeightRequest="48" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star, cliped by parent size." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="5" WidthRequest="48"> @@ -112,7 +110,7 @@ HeightRequest="48" ImageSource="avatar_icon.png" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="1" WidthRequest="48" /> @@ -122,7 +120,7 @@ HeightRequest="48" ImageSource="https://aka.ms/campus.jpg" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="2" WidthRequest="48" /> @@ -132,7 +130,7 @@ HeightRequest="48" ImageSource="avatar_icon.png" SemanticProperties.Description="Sample AvatarView idea using a polyline stroke shape to override the corder radius to draw a star, cliped by parent size." - StrokeShape="Polyline 70,16 76,32 94,32 80,44 84,60 70,50 55,60 60,42 46,32 64,32" + StrokeShape="Polyline 24,0 29,16 48,18 34,30 38,48 24,37 10,48 14,30 0,18 19,16" Style="{StaticResource Rating}" Text="3" WidthRequest="48"> diff --git a/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupPositionPage.xaml b/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupPositionPage.xaml index 134d578dc..6f8979d27 100644 --- a/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupPositionPage.xaml +++ b/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupPositionPage.xaml @@ -13,25 +13,21 @@ - + VerticalOptions="Center">