Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTUS.Twitter: Latitude & Longitude as part of the Tweet. #727

Closed
SpilledMilkCOM opened this issue Dec 15, 2016 · 5 comments
Closed

MTUS.Twitter: Latitude & Longitude as part of the Tweet. #727

SpilledMilkCOM opened this issue Dec 15, 2016 · 5 comments

Comments

@SpilledMilkCOM
Copy link
Contributor

@SpilledMilkCOM SpilledMilkCOM commented Dec 15, 2016

I've already added the Lat/Long as part of the status update (PR#714), but I would like to display this in the
Sample App as well. I would like to make this as part of the Tweet object since it looks like the Lat/Long is coming back from the response. I was going to add this to my previous pull request, but since I already went outside the bounds of the process (and asking for forgiveness now) I wanted to run it by the community to see if this would be useful. It would be useful to ME as I could verify the lat/long is coming back correctly versus looking on the Twitter site and only seeing "Highlands Ranch, CO" or in some other cases "Colorado, USA". Twitter USED to show the lat/long pair WELL over a year ago, but now that's gone.

There are other features that I'd like to ad to the Sample App:

  • o Only have to type in the keys and callback Uri once. Copying and pasting this into the UI is very time consuming every time I want to test. These could be saved to local storage and you're good.
  • o Launch BingMaps using the launcher to VIEW the lat/long as well.

Updating the toolkit:

  • o Since I added the other options (as well as Lat/Long) to the status update, then we probably should be retrieving these values as well.
@deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Dec 15, 2016

I like the idea of display tweets locations when available.

Some remarks though:

  1. These could be saved to local storage and you're good: you cannot as this is a security breach. You can else use the PasswordVault to do so
  2. The sample app is designed to be simple and only highlight toolkit features. So BingMaps is not relevant here

@SpilledMilkCOM
Copy link
Contributor Author

@SpilledMilkCOM SpilledMilkCOM commented Dec 18, 2016

I'll just do the lat/long and possibly the place coming back. I'll take a look at the PasswordVault for the keys. I thought that since I'm the one putting the keys in and it's being stored to MY LocalStorage then it would be safe under my account name. I may just grin and bear it and keep typing in my keys since I've got other projects to work on during my vacation.

Should I make a new fork for this? If I keep the same fork/clone I don't know if I'll get any of the latest changes. I don't know if that matters, but I don't want your merge to be a pain.

@deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Jan 4, 2017

You can fork and just pull the latest version from here

@deltakosh deltakosh closed this Feb 15, 2017
@deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Feb 15, 2017

Closing for now. Please reopen if required

@SpilledMilkCOM
Copy link
Contributor Author

@SpilledMilkCOM SpilledMilkCOM commented Feb 17, 2017

Yes. This is done. THANKS!!

@msftbot msftbot bot locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants