Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Sprite Offset-y doesn't respond to percentage #1012

Open
JaredSartin opened this Issue · 4 comments

3 participants

@JaredSartin

when you setup a sprite with +spritedir-sprite(icon-large, $offset-x: 100%, %offset-y: 50%) - the resulting sprite gets a background position of: 100% 50px.

Any number given to $offset-y is converted to px. This is all fine and dandy for vertical sprites, but horizontal ones need to do the 100% to the y offset.

Line 158 in compass / lib / compass / sass_extensions / functions / sprites.rb checks the x offset for percentage and uses it if there is, but nothing is done for the y offset - it just parses out the number and puts the px on there.

Fixes?

@JaredSartin

Was pretty simple... I couldn't find tests for this area, so I didn't include any.

@scottdavis
Owner

wip: #1014

@scottdavis scottdavis closed this
@chriseppstein

is not finished.

@chriseppstein chriseppstein reopened this
@chriseppstein

Should be on top of the changes coming in #1771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.