mother-effing hyphenation #788

Closed
chriseppstein opened this Issue Mar 14, 2012 · 8 comments

Comments

Projects
None yet
4 participants
Contributor

nickcooley commented Apr 4, 2012

Added with [bbdd701]

Chris, please let me know if you had something else in mind for this...

Thanks,

Contributor

ry5n commented Apr 4, 2012

@nickcooley You beat me to this! One thing I was considering was whether there should be some way to have word-break without hyphenation, and possibly (?) the other way round, eg. bare urls in a hyphenated passage probably should break, but hyphenation would be bad… I think I would have leaned to two mixins, +word-break and +hyphens, named the same as the css props, and maybe a third to include them both? @chriseppstein?

Contributor

nickcooley commented Apr 4, 2012

Ryan --

Thx for the feedback! Much appreciated! So, the initial inspiration for the mixin was blog post listed above. I think you make a really good point though and that is to create mixins for the lower level elements as well... I'll get cracking on that (as well as adding other mixins based on the CSS Text Level 3 spec while I'm at it: http://www.w3.org/TR/css3-text/#word-break).

To stay consistent with the spec, I may rename the partial to "_text" as all of these features fall under the CSS3 "Text" spec.

Thoughts on that?

Contributor

ry5n commented Apr 4, 2012

@nickcooley Awesome! Let me know if I can help further. As for where this should go in Compass, it’s Chris’ call.

Contributor

nickcooley commented Apr 4, 2012

@chriseppstein -- Do you have any thoughts about where this fits into existing mixin structure? Technically, like I said, word-breaks and hyphenation is all part of the CSS Text Lvl3 spec. But so are things like text-shadow (which has its own mixin.) or text-outline which technically could fall into it too...

Owner

chriseppstein commented Apr 4, 2012

where you have it seems ok

@nickcooley nickcooley added a commit to nickcooley/compass that referenced this issue Apr 6, 2012

@nickcooley nickcooley Mother-effing hyphenation
[#788] adds mixin for word-break and hyphens
4c10efc

@chriseppstein chriseppstein added a commit that referenced this issue May 28, 2012

@nickcooley @chriseppstein nickcooley + chriseppstein Mother-effing hyphenation
[#788] adds mixin for word-break and hyphens
8db0b40
Contributor

ry5n commented Oct 16, 2012

@chriseppstein Should this be closed now that it's been committed? @nickcooley Was there more work to do on this?

Contributor

nickcooley commented Oct 16, 2012

@ryanfrederick -- I didn't have any further activities to complete this ticket, so IMO once it was committed, the issue can be closed -- Obviously I will defer to @chriseppstein on that though.

Thanks,
nc

On Oct 15, 2012, at 10:23 PM, Ryan Frederick wrote:

@chriseppstein Should this be closed now that it's been committed? @nickcooley Was there more work to do on this?


Reply to this email directly or view it on GitHub.

scottdavis closed this Mar 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment